Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: normalize explicit empty instance name #71

Merged
merged 1 commit into from
Aug 11, 2023
Merged

fix: normalize explicit empty instance name #71

merged 1 commit into from
Aug 11, 2023

Conversation

falconandy
Copy link
Contributor

Summary

  1. Normalize explicit empty instance name to be DEFAULT_INSTANCE.
  2. Make 'read-only' some config values

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: no (incorrect assignments to read-only config values should be removed)

@justin-fiedler justin-fiedler merged commit ac60e5e into main Aug 11, 2023
3 checks passed
@justin-fiedler justin-fiedler deleted the AMP-70048-normalize-empty-instance-name branch August 11, 2023 17:49
github-actions bot pushed a commit that referenced this pull request Aug 11, 2023
@amplitude-sdk-bot
chore(release): 0.4.11 [skip ci]
903429a 
## [0.4.11](v0.4.10...v0.4.11) (2023-08-11)

### Bug Fixes

* normalize explicit empty instance name ([#71](#71)) ([ac60e5e](ac60e5e))
@github-actions
Copy link

🎉 This PR is included in version 0.4.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justin-fiedler justin-fiedler Awaiting requested review from justin-fiedler

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@falconandy @justin-fiedler