Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add support for CGFloat property values #91

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

ryancrosby-bl
Copy link
Contributor

Summary

Add support for sending CGFloat values in event properties.

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: no

@liuyang1520
Copy link
Collaborator

Thank you very much for contributing here!

The change looks good to me, have you tried to test it in a sample app, to see the event in Amplitude "User Look-Up"?

@liuyang1520 liuyang1520 requested review from liuyang1520 and a team October 16, 2023 22:51
@ryancrosby-bl
Copy link
Contributor Author

I pulled this branch into my host app and verified the values came through. Thanks for the quick response! Also, thank you for the Swift version of the SDK. I appreciate it.

@liuyang1520 liuyang1520 merged commit 6de48f0 into amplitude:main Oct 16, 2023
3 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 17, 2023
## [0.7.3](v0.7.2...v0.7.3) (2023-10-17)

### Bug Fixes

* add support for CGFloat property values ([#91](#91)) ([6de48f0](6de48f0))
@github-actions
Copy link

🎉 This PR is included in version 0.7.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants