feat: add method to get device ID synchronously #490
Conversation
|
Plan on adding a test case here too. |
There was a problem hiding this comment.
I don't think this needs to be a separate method - initializeDeviceID has no dependencies other than dbhelper which is set up at init, so it should be safe to call early from the regular accessor if the deviceID is nil.
It looks like the late binding is just to avoid db access on the main thread, if someone needs it earlier, we don't need to defer the work.
Sources/Amplitude/Amplitude.m
Outdated
| @@ -1669,19 +1669,21 @@ - (NSString *)getAdSupportID { | |||
| } | |||
|
|
|||
| - (NSString *)getDeviceId { | |||
| return self.deviceId; | |||
| return [self initializeDeviceId]; | |||
There was a problem hiding this comment.
@crleona So something like this?
There was a problem hiding this comment.
yeah, this works - we could only call initializeDeviceId on a nil check, but the overhead should be negligible and I doubt we're going to encounter any thread contention.
# [8.19.0](v8.18.3...v8.19.0) (2024-04-04) ### Features * add method to get device ID synchronously ([#490](#490)) ([f5066b2](f5066b2))
|
🎉 This PR is included in version 8.19.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Summary
Checklist