Do not create new functions in render. Fix #66

amplitude · Apr 23, 2017 · ec4ccf7 · ec4ccf7
1 parent 8ee71c9
commit ec4ccf7
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/src/components/connect-request.js b/src/components/connect-request.js
@@ -31,6 +31,8 @@ const connectRequest = (mapPropsToConfigs, options = {}) => WrappedComponent =>
         constructor() {
             super();
 
+            this.forceRequest = this.forceRequest.bind(this)
+
             // A set of URLs that identify all pending requests
             this._pendingRequests = {};
             this._wrappedInstance = null;
@@ -115,22 +117,23 @@ const connectRequest = (mapPropsToConfigs, options = {}) => WrappedComponent =>
             }
         }
 
-        render() {
-            const configs = mapPropsToConfigs(this.props);
-            const forceRequest = partial(this.requestAsync.bind(this), configs, true, false);
+        forceRequest() {
+            this.requestAsync(mapPropsToConfigs(this.props), true, false);
+        }
 
+        render() {
             if (withRef) {
                 return (
                     <WrappedComponent
                         {...this.props}
-                        forceRequest={forceRequest}
+                        forceRequest={this.forceRequest}
                         ref={ref => {
                             this._wrappedInstance = ref;
                         }}
                     />
                 );
             } else {
-                return <WrappedComponent {...this.props} forceRequest={forceRequest} />;
+                return <WrappedComponent {...this.props} forceRequest={this.forceRequest} />;
             }
         }
     }