Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exchange react-pure-render dependency with react-addons-shallow-compare #27

Merged
merged 2 commits into from
Feb 28, 2017

Conversation

mmalfertheiner
Copy link

Hi,

thanks for this awesome library. The library works great with react, but I was not able to use it with react-native due to the react-pure-render dependency. For this reason I replaced the react-pure-render dependency with react-addons-shallow-compare.

All the best,

Martin

@codecov-io
Copy link

Codecov Report

Merging #27 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #27   +/-   ##
=======================================
  Coverage   90.14%   90.14%           
=======================================
  Files           7        7           
  Lines         213      213           
=======================================
  Hits          192      192           
  Misses         21       21

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba5e669...dead6fd. Read the comment docs.

@ryanashcraft
Copy link
Contributor

@mmalfertheiner You're using this redux-query with react-native? If so, that's awesome.

Thanks for the PR. This is a good change anyways because apparently react-pure-render is deprecated in favor of react-addons-shallow-compare.

@ryanashcraft ryanashcraft merged commit 99e70ab into amplitude:master Feb 28, 2017
@mmalfertheiner
Copy link
Author

Yes I do and with this small fix it works very well. Thanks for the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants