-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let superagent handle request body #57
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,43 +1,47 @@ | ||
import { assert } from 'chai'; | ||
import * as HTTPMethods from '../../src/constants/http-methods'; | ||
import superagentAdapter, { createRequest } from '../../src/adapters/superagent'; | ||
import superagentAdapter from '../../src/adapters/superagent'; | ||
|
||
describe('superagent adapter', () => { | ||
it('must return an object with both execute and abort functions', () => { | ||
it('must return an object with both execute and abort functions, as well as the request instance', () => { | ||
const adapter = superagentAdapter('http://localhost', HTTPMethods.GET); | ||
assert.isFunction(adapter.execute); | ||
assert.isFunction(adapter.abort); | ||
assert(adapter.instance); | ||
}); | ||
|
||
describe('createRequest', () => { | ||
it('must return a DELETE request when supplied a DELETE method', () => { | ||
const request = createRequest('http://localhost', HTTPMethods.DELETE); | ||
assert.equal(request.method, HTTPMethods.DELETE); | ||
}); | ||
|
||
it('must return a GET request when supplied a GET method', () => { | ||
const request = createRequest('http://localhost', HTTPMethods.GET); | ||
assert.equal(request.method, HTTPMethods.GET); | ||
}); | ||
|
||
it('must return a PATCH request when supplied a PATCH method', () => { | ||
const request = createRequest('http://localhost', HTTPMethods.PATCH); | ||
assert.equal(request.method, HTTPMethods.PATCH); | ||
}); | ||
|
||
it('must return a POST request when supplied a POST method', () => { | ||
const request = createRequest('http://localhost', HTTPMethods.POST); | ||
assert.equal(request.method, HTTPMethods.POST); | ||
}); | ||
|
||
it('must return a PUT request when supplied a PUT method', () => { | ||
const request = createRequest('http://localhost', HTTPMethods.PUT); | ||
assert.equal(request.method, HTTPMethods.PUT); | ||
}); | ||
|
||
it('must throw an error when supplied an invalid HTTP method', () => { | ||
const request = () => createRequest('http://localhost', 'abc'); | ||
assert.throws(request, /Unsupported HTTP method/); | ||
}); | ||
it('must return a HEAD request when supplied a HEAD method', () => { | ||
const { instance } = superagentAdapter('http://localhost', HTTPMethods.HEAD); | ||
assert.equal(instance.method, HTTPMethods.HEAD); | ||
}); | ||
|
||
it('must return a DELETE request when supplied a DELETE method', () => { | ||
const { instance } = superagentAdapter('http://localhost', HTTPMethods.DELETE); | ||
assert.equal(instance.method, HTTPMethods.DELETE); | ||
}); | ||
|
||
it('must return a GET request when supplied a GET method', () => { | ||
const { instance } = superagentAdapter('http://localhost', HTTPMethods.GET); | ||
assert.equal(instance.method, HTTPMethods.GET); | ||
}); | ||
|
||
it('must return a PATCH request when supplied a PATCH method', () => { | ||
const { instance } = superagentAdapter('http://localhost', HTTPMethods.PATCH); | ||
assert.equal(instance.method, HTTPMethods.PATCH); | ||
}); | ||
|
||
it('must return a POST request when supplied a POST method', () => { | ||
const { instance } = superagentAdapter('http://localhost', HTTPMethods.POST); | ||
assert.equal(instance.method, HTTPMethods.POST); | ||
}); | ||
|
||
it('must return a PUT request when supplied a PUT method', () => { | ||
const { instance } = superagentAdapter('http://localhost', HTTPMethods.PUT); | ||
assert.equal(instance.method, HTTPMethods.PUT); | ||
}); | ||
|
||
it('must throw an error when supplied an invalid HTTP method', () => { | ||
const invalid = () => superagentAdapter('http://localhost', 'abc'); | ||
assert.throws(invalid, /Unsupported HTTP method/); | ||
}); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you keep this function and the switch statement for explicitness?
in addition, we can move to making this function not exported with your change in tests/. that would be great
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done 👍 let me know if you need anything else