Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bundle-size] [test-status] Connect to the database using a JSON-stringified connection object in .env #675

Merged

Conversation

danielrozenberg
Copy link
Member

This will make it possible to enable cloud deploy on bundle-size and test-status (see #664)

Ideally once iceddev/pg-connection-string#34 is merged and the new version is used by Knex as a dependency, we can switch to using a connection URL instead

@danielrozenberg danielrozenberg merged commit 0c146e0 into ampproject:master Jan 30, 2020
@danielrozenberg danielrozenberg deleted the database-connection branch January 30, 2020 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants