Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deduplication of AMP scripts and improve ReorderHead transformer #130

Merged

Conversation

westonruter
Copy link
Member

@westonruter westonruter commented Apr 6, 2021

Ports (and depends on) ampproject/amp-toolbox#1192. See ampproject/amp-toolbox#1191. Fixes #125.

@westonruter westonruter added this to the 0.4.0 milestone Apr 6, 2021
westonruter added a commit to ampproject/amp-wp that referenced this pull request Apr 7, 2021
@westonruter westonruter changed the title Deduplicate scripts by src as opposed to custom-element/custom-template attrs Fix deduplication of AMP scripts Apr 7, 2021
@westonruter westonruter changed the title Fix deduplication of AMP scripts Fix deduplication of AMP scripts and improve ReorderHead transformer Apr 7, 2021
.phpcs.xml.dist Outdated Show resolved Hide resolved
src/Amp.php Show resolved Hide resolved
@schlessera schlessera added Bug Something isn't working Optimizer labels Apr 7, 2021
@schlessera
Copy link
Collaborator

I'm merging this into the PR #119 to simplify testing in the WP plugin.

@schlessera schlessera merged commit f8a8c47 into add/20-rewrite-amp-urls-transformer Apr 7, 2021
@schlessera schlessera deleted the fix/reorder-head-deduplication branch April 7, 2021 15:00
schlessera pushed a commit to ampproject/amp-wp that referenced this pull request Apr 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Optimizer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants