-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deduplication of AMP scripts and improve ReorderHead transformer #130
Merged
schlessera
merged 18 commits into
add/20-rewrite-amp-urls-transformer
from
fix/reorder-head-deduplication
Apr 7, 2021
Merged
Fix deduplication of AMP scripts and improve ReorderHead transformer #130
schlessera
merged 18 commits into
add/20-rewrite-amp-urls-transformer
from
fix/reorder-head-deduplication
Apr 7, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
westonruter
added a commit
to ampproject/amp-wp
that referenced
this pull request
Apr 7, 2021
westonruter
changed the title
Deduplicate scripts by src as opposed to custom-element/custom-template attrs
Fix deduplication of AMP scripts
Apr 7, 2021
westonruter
changed the title
Fix deduplication of AMP scripts
Fix deduplication of AMP scripts and improve ReorderHead transformer
Apr 7, 2021
schlessera
requested changes
Apr 7, 2021
I'm merging this into the PR #119 to simplify testing in the WP plugin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports (and depends on) ampproject/amp-toolbox#1192. See ampproject/amp-toolbox#1191. Fixes #125.