Update dependencies and spec tests - 2020-02-03

[schlessera]

This PR updates the spec tests imported from the Node.JS toolbox and either fixes or ignores test breakage.

Follow-up issues for ignored tests:

• Add missing amp-ad ending tag amp-toolbox#1135
• Adapt PreloadHeroImages to support new OptimizeHeroImage configuration arguments #55

[codecov]

Codecov Report

Merging #56 (ac4edbd) into main (60f6d0c) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main      #56      +/-   ##
============================================
- Coverage     78.40%   78.27%   -0.13%     
- Complexity      854      858       +4     
============================================
  Files            47       47              
  Lines          2139     2145       +6     
============================================
+ Hits           1677     1679       +2     
- Misses          462      466       +4     

Flag	Coverage Δ	Complexity Δ
php	78.27% <100.00%> (-0.13%)	0.00 <6.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ	Complexity Δ
src/Optimizer/Transformer/PreloadHeroImage.php	89.95% <100.00%> (-1.88%)	89.00 <0.00> (ø)
src/Optimizer/Transformer/ServerSideRendering.php	84.77% <100.00%> (+0.23%)	143.00 <6.00> (+4.00)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf04487...2072f35. Read the comment docs.

[westonruter]

LGTM

[westonruter]

Technically this could also check if $parent->getAttribute('type') === 'text/plain':

Suggested change

	if ($parent->tagName === Tag::SCRIPT && $parent->hasAttribute(Attribute::TEMPLATE)) {
	if ($parent->tagName === Tag::SCRIPT && $parent->hasAttribute(Attribute::TEMPLATE) && $parent->getAttribute('type') === 'text/plain') {

But that would be somewhat overkill since template implies type=text/plain

[schlessera]

Yes, I think that would not add any benefit, but only add additional overhead and maybe even create false negatives in the worst case.