PX: escape html in suggestions (#1172)

ampproject · Mar 22, 2021 · 299dc5d · 299dc5d
1 parent 0974deb
commit 299dc5d
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/packages/page-experience/lib/checks/earlyIframes.js b/packages/page-experience/lib/checks/earlyIframes.js
@@ -32,7 +32,7 @@ const earlyIframes = (pageData, result) => {
   result.addDetails({
     headings: [{label: 'src', valueType: 'text', key: 'src'}],
     items: pageData.criticalIframes.map((iframeSrc) => {
-      return {src: iframeSrc};
+      return {src: `\`${iframeSrc}\``};
     }),
   });
 };

diff --git a/packages/page-experience/lib/checks/heroImages.js b/packages/page-experience/lib/checks/heroImages.js
@@ -38,7 +38,7 @@ const heroImages = (pageData, result) => {
     headings: [{label: 'Affected images', valueType: 'text', key: 'image'}],
     items: heroImageCandidates.map((img) => {
       return {
-        image: `<amp-img data-hero src="${img.src}" layout="${img.src}" width="${img.src}" height="${img.src}" ...>`,
+        image: `\`<amp-img src="${img.src}" layout="${img.src}" width="${img.src}" height="${img.src}" ...>\``,
       };
     }),
   });

diff --git a/packages/page-experience/test-data/checks/earlyIframes/iframe-in-first-viewport.json b/packages/page-experience/test-data/checks/earlyIframes/iframe-in-first-viewport.json
@@ -10,7 +10,7 @@
       ],
       "items": [
         {
-          "src": "https://www.google.com/maps/embed/v1/place?key=AIzaSyAyAS599A2GGPKTmtNr9CptD61LE4gN6oQ&q=iceland"
+          "src": "`https://www.google.com/maps/embed/v1/place?key=AIzaSyAyAS599A2GGPKTmtNr9CptD61LE4gN6oQ&q=iceland`"
         }
       ]
     }

diff --git a/packages/page-experience/test-data/checks/heroImages/image-in-first-viewport.json b/packages/page-experience/test-data/checks/heroImages/image-in-first-viewport.json
@@ -10,7 +10,7 @@
       ],
       "items": [
         {
-          "image": "<amp-img data-hero src=\"/image.jpg\" layout=\"/image.jpg\" width=\"/image.jpg\" height=\"/image.jpg\" ...>"
+          "image": "`<amp-img src=\"/image.jpg\" layout=\"/image.jpg\" width=\"/image.jpg\" height=\"/image.jpg\" ...>`"
         }
       ]
     }