Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 Add icomoon #1149

Merged
merged 3 commits into from
Feb 26, 2021
Merged

🔧 Add icomoon #1149

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cfad7f8
:wrench: Add more font-famlies
lluerich Feb 26, 2021
f244a7b
:wrench: Remove octicons
lluerich Feb 26, 2021
80d1e65
:white_check_mark: Add some more tests
lluerich Feb 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/linter/src/rules/NoIconFontIsUsed.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ const ICON_FONT_IDENTIFIERS = [
},
{
className: "icon-",
fontFamilies: ["icon"],
fontFamilies: ["icon", "icons", "icomoon"],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test case? Have we already got tests for all the icon font providers?

},
];

Expand Down