Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix postinstall failing on windows #770

Merged
merged 1 commit into from
May 13, 2020
Merged

Conversation

sebastianbenz
Copy link
Collaborator

Change from executing a script on postinstall to invoking the cache
warmup via node lib/warmup.js.

This also improves logging during postinstall.

Change from executing a script on postinstall to invoking the cache
warmup via `node lib/warmup.js`.

This also improves logging during postinstall.
Copy link
Member

@andreban andreban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebastianbenz sebastianbenz merged commit 70ad97b into master May 13, 2020
@sebastianbenz sebastianbenz deleted the fix-windows-postinstall branch May 13, 2020 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants