Move hero image preload out of experimental #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickkettner
approved these changes
Jun 3, 2020
| } | ||
| } | ||
| return false; | ||
| } |
There was a problem hiding this comment.
continuing my series of "unhelpful comments that make the code less readable"...
return [...head.children].any(this.isImagePreload)There was a problem hiding this comment.
Why the destructuring? I think head.children.some(this.isImagePreload); does the trick as well (and is easy to read).
| @@ -6,6 +6,7 @@ | |||
| <link rel="preload" href="https://cdn.ampproject.org/v0.js" as="script"> | |||
| <script data-auto async src="https://cdn.ampproject.org/v0.js"></script> | |||
| <script async src="https://cdn.ampproject.org/v0/amp-video-0.1.js" custom-element="amp-video"></script> | |||
| <link rel="preload" href="https://amp.dev/static/samples/img/tokyo.jpg" as="image" data-hero> | |||
There was a problem hiding this comment.
just for my own edification - what is the purpose of the data attr?
There was a problem hiding this comment.
For being able to track which images have been identified as hero images
|
For images that have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also changes the transformer to only run if there a no pre-existing image preloads.