Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(optimizer): add missing dependency node-fetch #838

Merged
merged 1 commit into from
Jun 15, 2020

Conversation

merceyz
Copy link
Contributor

@merceyz merceyz commented Jun 12, 2020

What's the problem this PR addresses?

In #835 @ampproject/toolbox-optimizer started using node-fetch but didn't declare it as a dependency.

How did you fix it?

Add missing dependency node-fetch

@sebastianbenz sebastianbenz merged commit 3023d91 into ampproject:master Jun 15, 2020
@sebastianbenz
Copy link
Collaborator

Sorry about missing this again. Is there a simple way to check this via linter?

@merceyz
Copy link
Contributor Author

merceyz commented Jun 15, 2020

Sorry about missing this again

No worries 👍

Is there a simple way to check this via linter?

Yes, there is a ESLint plugin that can handle this.
https://github.com/benmosher/eslint-plugin-import
https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-extraneous-dependencies.md

@sebastianbenz
Copy link
Collaborator

sebastianbenz commented Jun 15, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants