amp-img ssr: don't generate sizes attribute #32644
Assignees
Comments
kristoferbaxter
added
Type: Feature Request
WG: components
P1: High Priority
and removed
Type: Bug
labels
sebastianbenz
added a commit
to ampproject/amp-toolbox
that referenced
this issue
Feb 12, 2021
Workaround for ampproject/amphtml#32644.
sebastianbenz
added a commit
to ampproject/amp-toolbox
that referenced
this issue
Feb 15, 2021
* Don't remove sizes for hero images Workaround for ampproject/amphtml#32644. * generate default sizes attribute for hero images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
Server-side rendering a hero image can cause double download of the same image when using
srcsetbut notsizes. The problem is: the amp-img extension in that case generates a viewport specific sizes attribute which might cause a re-download of the same image.Steps to reproduce
Load https://lava-useful-horesradish.glitch.me/ in DevTools simulating a mobile device, e.g. G4. You can see that the image is downloaded twice:
Suggested fix
Don't generate a sizes attribute for ssr'd
img. There's no value in setting this anyway, as the user agent has already decided at this point in time which image to download.//cc @patrickkettner @jridgewell
The text was updated successfully, but these errors were encountered: