🚨 Error: Cannot read property 'then' of undefined

[ampprojectbot]

Details

Error report: link
First seen: May 18, 2021
Frequency: ~ 1,067/day

Stacktrace

Error: Cannot read property 'then' of undefined
    at then (src/amp-story-player/amp-story-player-impl.js:1399:27)
    at updateVisibilityState_ (src/amp-story-player/amp-story-player-impl.js:372:9)
    at togglePaused_ (src/amp-story-player/amp-story-player-impl.js:360:9)
    at pause (src/custom-element.js:707:13)
    at unmount (src/service/resource.js:1035:17)
    at unload (src/service/resources-impl.js:1677:10)
    at forEach (src/service/resources-impl.js:1676:22)
    at callback (src/core/data-structures/finite-state-machine.js:53:60)
    at setState (src/service/resources-impl.js:652:33)

Notes

@Enriqe modified src/amp-story-player/amp-story-player-impl.js:1399-1401 in #32153 (Feb 1, 2021)
@dvoytenko modified src/custom-element.js:688-709 in #33272 (Mar 18, 2021)
@dvoytenko modified src/service/resource.js:1035-1035 in #33272 (Mar 18, 2021)
@renovate-bot modified src/service/resources-impl.js:1676-1676 in #27350 (Mar 30, 2020)
@rcebulko modified src/core/data-structures/finite-state-machine.js:53-53 in #34367 (May 14, 2021)
@dvoytenko modified src/service/resources-impl.js:652-652 in #24566 (Sep 20, 2019)

Seen in:

• 08-13 Control (2216)
• 08-13 Nightly-Control (2216)
• 08-13 Stable (2216)
• 08-19 Beta (2119)
• 08-19 Experiment-B (2119)
• 08-27 Nightly (0538)
• +1 more

Possible assignees: @dvoytenko, @Enriqe

/cc @ampproject/release-on-duty

[gmajoulet]

Looks like AMP custom element calls pause() that we publicly expose to publishers. We could just rename our internal method but not change the public API.

cc @ampproject/wg-stories