Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove visibilityState from viewer #24566

Merged
merged 6 commits into from
Sep 20, 2019
Merged

Conversation

dvoytenko
Copy link
Contributor

@dvoytenko dvoytenko commented Sep 16, 2019

Partial for #22733.

src/chunk.js Outdated Show resolved Hide resolved
@dvoytenko dvoytenko marked this pull request as ready for review September 18, 2019 22:13
Copy link
Member

@cramforce cramforce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the chunks part. One comment.

src/chunk.js Outdated Show resolved Hide resolved
@dvoytenko dvoytenko merged commit d98f2e3 into ampproject:master Sep 20, 2019
@dvoytenko dvoytenko deleted the ampdoc-fie2 branch September 20, 2019 05:01
zhouyx added a commit that referenced this pull request Oct 4, 2019
This was referenced Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants