Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement IntersectionObserver polyfill for 3p iframe #720

Closed
cramforce opened this issue Oct 22, 2015 · 1 comment
Closed

Implement IntersectionObserver polyfill for 3p iframe #720

cramforce opened this issue Oct 22, 2015 · 1 comment
Assignees
@cramforce
Labels
WG: monetization

Comments

@cramforce
Copy link
Member

Spec is here
http://rawgit.com/slightlyoff/IntersectionObserver/master/index.html
More info: https://github.com/slightlyoff/IntersectionObserver

  • The data would come from the parent iframe / AMP resource manager.
  • Only polyfill data we have easily available
  • Need to decide poll interval
  • Need to decide whether to actually polyfill OR just make a very similar API.
  • Probably the latter, exposed through a single object (no exposed constructor) in the frame: context.intersectionObserver
@cramforce cramforce self-assigned this Oct 22, 2015
@cramforce
Copy link
Member Author

Update ads/README.md when completed.

@cramforce cramforce mentioned this issue Nov 7, 2015
Merged
cramforce added a commit to cramforce/amphtml that referenced this issue Nov 10, 2015
@cramforce
Exposes window.context.observeIntersection to ads that provides lar…
8a800f9 
…gely IntersectionObserver compatible change records of the ad's position in the container viewport.

Also makes the following advancements:
- 3p frames now check that the claimed origin of the parent is correct. This helps ads trust the parent.
- Adds tests for integration.js
- adds `3p-frame/listenOnce,postMessage`
- adds `rectIntersection` to layout-rect.js

Fixes ampproject#720
@uditalias uditalias mentioned this issue Nov 4, 2022
Open
@Elisabeth1983 Elisabeth1983 mentioned this issue Nov 4, 2022
Open
@Masterci84 Masterci84 mentioned this issue Nov 5, 2022
Open
@muratkalenderoglu muratkalenderoglu mentioned this issue Nov 5, 2022
Open
@terrorizer1980 terrorizer1980 mentioned this issue Nov 5, 2022
Closed
@shmoop207 shmoop207 mentioned this issue Nov 15, 2022
Open
@Elisabeth1983 Elisabeth1983 mentioned this issue Nov 15, 2022
Open
@Masterci84 Masterci84 mentioned this issue Nov 16, 2022
Open
@muratkalenderoglu muratkalenderoglu mentioned this issue Nov 16, 2022
Open
@terrorizer1980 terrorizer1980 mentioned this issue Nov 16, 2022
Closed
@shmoop207 shmoop207 mentioned this issue Nov 28, 2022
Open
@Elisabeth1983 Elisabeth1983 mentioned this issue Nov 28, 2022
Open
@Masterci84 Masterci84 mentioned this issue Nov 28, 2022
Open
@muratkalenderoglu muratkalenderoglu mentioned this issue Nov 29, 2022
Open
@terrorizer1980 terrorizer1980 mentioned this issue Nov 29, 2022
Closed
@Elisabeth1983 Elisabeth1983 mentioned this issue Dec 25, 2022
Open
@shmoop207 shmoop207 mentioned this issue Dec 25, 2022
Open
@Elisabeth1983 Elisabeth1983 mentioned this issue Dec 25, 2022
Open
@Masterci84 Masterci84 mentioned this issue Dec 25, 2022
Open
@muratkalenderoglu muratkalenderoglu mentioned this issue Dec 26, 2022
Open
@terrorizer1980 terrorizer1980 mentioned this issue Dec 26, 2022
Closed
@Elisabeth1983 Elisabeth1983 mentioned this issue Oct 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cramforce cramforce

Labels
WG: monetization
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cramforce @camelburrito