Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook up closure compiler #86

Closed
cramforce opened this issue Sep 11, 2015 · 4 comments
Closed

Hook up closure compiler #86

cramforce opened this issue Sep 11, 2015 · 4 comments
Assignees

Comments

@cramforce
Copy link
Member

Step 1: Get things to compile
Step 2: Use it for codegen. In particular for ES6 to ES(3) compilation.

@erwinmombay erwinmombay self-assigned this Oct 9, 2015
jaboc83 added a commit to jaboc83/amphtml that referenced this issue Oct 28, 2015
In support of ampproject#86 "Hook up closure compiler"
@cramforce
Copy link
Member Author

Well Step 2 is kinda still pending. Also need to use it for all compilation targets. Currently only hooked it up for amp.js.

@erwinmombay erwinmombay reopened this Jan 8, 2016
@jridgewell
Copy link
Contributor

If we're changing to closure to eliminate the browserify bloat, might I suggest using rollup instead?

@erwinmombay
Copy link
Member

yeah, rollup would be great to check out just to see the difference. we still probably want to get a fully type checked code base at some point with closure though.

@cramforce
Copy link
Member Author

It is worth a try if not too much work. We also want type checking, DCE,
etc.

The code rollup generates looks pretty good.
On Jan 8, 2016 2:14 PM, "erwin mombay" [email protected] wrote:

yeah, rollup would be great to check out just to see the difference.


Reply to this email directly or view it on GitHub
#86 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants