-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hook up closure compiler #86
Comments
In support of ampproject#86 "Hook up closure compiler"
Well Step 2 is kinda still pending. Also need to use it for all compilation targets. Currently only hooked it up for amp.js. |
If we're changing to closure to eliminate the browserify bloat, might I suggest using rollup instead? |
yeah, rollup would be great to check out just to see the difference. we still probably want to get a fully type checked code base at some point with closure though. |
It is worth a try if not too much work. We also want type checking, DCE, The code rollup generates looks pretty good.
|
Step 1: Get things to compile
Step 2: Use it for codegen. In particular for ES6 to ES(3) compilation.
The text was updated successfully, but these errors were encountered: