fix(cid): localhost should only be considered as proxy if prefix is c or v.

[erwinmombay]

No description provided.

[cramforce]

Do the unit tests still go through the same code path?

[erwinmombay]

@cramforce with this current code, i can't 100% guarantee that. i think there could certainly be an indirect use of the cid service in the tests that used to go through the getBaseCid path but would now go through the Promise.resolve path. (any test that had cid usage where url is localhost w/o v or c prefix).

im thinking of just removing the changes i made and doing this:

  if (url.origin.indexOf('http://localhost:') != 0) {
    assert(prefix == 'c' || prefix == 'v',
        'Unknown path prefix in url %s', url.href);
  }

in getSourceOrigin which fixes my localhost warning problems and would ensure all tests still go through the same code path.

[cramforce]

I'm confused by the changeset that GH is showing now. Otherwise it was fine.

[jridgewell]

This LGTM. What's the v prefix for?

[erwinmombay]

@cramforce i dont think i was confident that the previous code wouldn't be forcing the tests into the Promise.resolve path (a test using localhost:8000/test for example). had to change from localDev since localDev also checks that the files come from dist or base (should we just remove that check in localDev?).

not sure what the v/c stands for, @cramforce can you shed some light on that one?

[cramforce]

I think what we discussed was to instead make #isProxyOrigin only return true if the assert would not fail.

[erwinmombay]

@cramforce reverted to original change. PTAL

[erwinmombay]

@cramforce PTAL. changed to check if localhost has prefix c/v

[cramforce]

LGTM