amp-bind: Warn during verify instead of error #13236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreamofabear
force-pushed
the
verify-to-warn
branch
from
0f39620
to
456a90b
Compare
dreamofabear
force-pushed
the
verify-to-warn
branch
from
c337991
to
5724966
Compare
jridgewell
approved these changes
Feb 7, 2018
dreamofabear
pushed a commit
that referenced
this pull request
Feb 7, 2018
This reverts commit 537a7d9.
protonate
pushed a commit
to protonate/amphtml
that referenced
this pull request
Feb 26, 2018
* change amp-bind verification to user warning and clarify message * fix presubmit * fix test
RanAbram
pushed a commit
to RanAbram/amphtml
that referenced
this pull request
Mar 12, 2018
* change amp-bind verification to user warning and clarify message * fix presubmit * fix test
protonate
pushed a commit
to protonate/amphtml
that referenced
this pull request
Mar 15, 2018
* change amp-bind verification to user warning and clarify message * fix presubmit * fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also update the warning message to be less scary sounding. We've gotten a lot confused users due to this e.g. #9862 (comment).
/to @jridgewell @alabiaga