Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛🏗 Formatting fix for bundlesize output #15112

Merged
merged 1 commit into from
May 7, 2018
Merged

🐛🏗 Formatting fix for bundlesize output #15112

merged 1 commit into from
May 7, 2018

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented May 5, 2018

gulp bundle-size used to show its results properly, but the formatting broke with the new version of ansi-colors, which can now color an array of strings. (The old version used to color and return just arr[0].)

This PR explicitly formats the output to show just the result from bundlesize without other extraneous stuff.

Follow up to #15066
Related to #14394
Related to #14392

@rsimha rsimha requested a review from jridgewell May 5, 2018 19:00
@rsimha
Copy link
Contributor Author

rsimha commented May 5, 2018

/to @choumx @jridgewell

@rsimha
Copy link
Contributor Author

rsimha commented May 7, 2018

Tested locally. Merging this, since things are broken on master.

@rsimha rsimha merged commit 4693fae into ampproject:master May 7, 2018
@rsimha rsimha deleted the 2018-05-05-FixBundlesize branch May 7, 2018 02:15
noranazmy pushed a commit to noranazmy/amphtml that referenced this pull request May 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants