Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding PubMatic OpenWrap Vendor ✨ #17052

Merged
merged 5 commits into from
Aug 2, 2018

Conversation

pm-harshad-mane
Copy link
Contributor

@pm-harshad-mane pm-harshad-mane commented Jul 24, 2018

✨ Adding PubMatic OpenWrap Vendor

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@pm-harshad-mane
Copy link
Contributor Author

Hello @choumx or @jridgewell , need your assistance

FAIL ./dist/v0.js: 79.24KB > maxSize 79.24KB (gzip)
[18:57:20] ERROR: bundlesize found that ./dist/v0.js has exceeded its size cap of 79.24KB.
[18:57:20] This is part of a new effort to reduce AMP's binary size (#14392).
[18:57:20] Please contact @choumx or @jridgewell for assistance.

@pm-harshad-mane
Copy link
Contributor Author

PubMatic has signed CLA, we faced a similar issue with CLA when we raised #13911 in April 2018.

@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@codecov-io
Copy link

codecov-io commented Jul 27, 2018

Codecov Report

Merging #17052 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #17052      +/-   ##
==========================================
- Coverage   77.88%   77.87%   -0.01%     
==========================================
  Files         562      562              
  Lines       41154    41165      +11     
==========================================
+ Hits        32052    32058       +6     
- Misses       9102     9107       +5
Flag Coverage Δ
#integration_tests 36.17% <ø> (ø) ⬆️
#unit_tests 76.93% <ø> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3dd1cc...0b8099e. Read the comment docs.

@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@erwinmombay
Copy link
Member

ping @keithwrightbos @bradfrizzell for review

@pm-harshad-mane
Copy link
Contributor Author

Hello @keithwrightbos and @bradfrizzell
Please review the PR.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@pm-harshad-mane
Copy link
Contributor Author

Hello @bradfrizzell ,
All checks are passed, can you please merge the changes?

@bradfrizzell bradfrizzell merged commit f1eed9d into ampproject:master Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants