Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Prevent toggle() from throwing error when no elements are selected. #20795

Merged
merged 6 commits into from
Feb 15, 2019
Merged

🐛 Prevent toggle() from throwing error when no elements are selected. #20795

merged 6 commits into from
Feb 15, 2019

Commits on Feb 12, 2019

  1. Check for undefined parameter in clearSelection_()

    @caroqliu
    caroqliu committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    55168f8 View commit details
    Browse the repository at this point in the history

  2. Create example file to test changes locally.

    @caroqliu
    caroqliu committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    fa0e71a View commit details
    Browse the repository at this point in the history

  3. Reorganize elements in <head>

    @caroqliu
    caroqliu committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    007a5b9 View commit details
    Browse the repository at this point in the history

  4. Remove guard from clearSelection()

    @caroqliu
    caroqliu committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    b896a0e View commit details
    Browse the repository at this point in the history

  5. Add undefined check to toggle() before calling clearSelection()

    @caroqliu
    caroqliu committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    60146fd View commit details
    Browse the repository at this point in the history

  6. Add undefined check to select() before calling clearSelection()

    @caroqliu
    caroqliu committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    8fa3487 View commit details
    Browse the repository at this point in the history