Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Assert that values are never returned from vsync callbacks #20836

Merged
merged 5 commits into from
Feb 14, 2019
Merged

🐛 Assert that values are never returned from vsync callbacks #20836

merged 5 commits into from
Feb 14, 2019

Commits on Feb 13, 2019

  1. Assert that values are never returned from vsync callbacks 

    Vsync does not propogate those values in any way. This is specifically targetting code like:

```js
vsync.measure(() => {
  return el.getBoundingClientRect();
});

// or
vsync.mutatePromise(() => {
  return someOtherPromise;
});
```
    @jridgewell
    jridgewell committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    9fd6cc6 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2019

  1. Fix dev call

    @jridgewell
    jridgewell authored Feb 14, 2019
    Configuration menu
    Copy the full SHA
    6c57619 View commit details
    Browse the repository at this point in the history

  2. Lint

    @jridgewell
    jridgewell committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    3a4bb02 View commit details
    Browse the repository at this point in the history

  3. Don't use devAssert so this stays in production

    @jridgewell
    jridgewell committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    1e1f15a View commit details
    Browse the repository at this point in the history

  4. Type checks

    @jridgewell
    jridgewell committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    754139a View commit details
    Browse the repository at this point in the history