Update sidebar v0.2 + nested menu and remove history API #25048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @rcebulko, these files were changed:
|
cathyxz
reviewed
Oct 16, 2019
rcebulko
approved these changes
Oct 16, 2019
cathyxz
reviewed
Oct 16, 2019
cathyxz
reviewed
Oct 23, 2019
| 'amp-drilldown-submenu', | ||
| 'amp-drilldown-submenu-open', | ||
| 'amp-drilldown-submenu-close', | ||
| // Attributes for amp-nested-menu. |
There was a problem hiding this comment.
@choumx could you take a look at this for owners bot?
This is a strict renaming of an unlaunched component.
dreamofabear
approved these changes
Oct 24, 2019
micajuine-ho
pushed a commit
to micajuine-ho/amphtml
that referenced
this pull request
Dec 27, 2019
…25048) * change sidebar version, update naming and remove history api from nested menu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I2I: #25049
resolves #24382, #24668
This PR makes the following updates to support the new version of
amp-sidebar:<amp-nested-menu>;