Add an experiment to disable sidebar history manipulation in iOS #25247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcebulko
reviewed
Oct 25, 2019
| @@ -315,4 +315,9 @@ export const EXPERIMENTS = [ | |||
| spec: 'https://github.com/ampproject/amphtml/issues/24168', | |||
| cleanupIssue: 'https://github.com/ampproject/amphtml/issues/24169', | |||
| }, | |||
| { | |||
| id: 'amp-sidebar-disable-history-ios', | |||
There was a problem hiding this comment.
Is there any spec thread for this?
There was a problem hiding this comment.
Also, as I'm looking at this file, what's the benefit of it being JS instead of JSON?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experiment to disable history manipulation in sidebar for iOS. This is one proposed solution to the sidebar UI glitch in #25251.