Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validator Updates #3282

Merged
merged 6 commits into from
May 24, 2016
Merged

Validator Updates #3282

merged 6 commits into from
May 24, 2016

Conversation

powdercloud
Copy link
Contributor

Release Notes

  • Allow whitespace at beginning and end of the boilerplate.

@powdercloud
Copy link
Contributor Author

Ah, there's a lint error (false positive showing up due to introducing the same previously whitelisted stuff in a new filename ...). Will try to fix this and say hi on this thread again.

@powdercloud powdercloud mentioned this pull request May 23, 2016
Merged
powdercloud added a commit that referenced this pull request May 24, 2016
@powdercloud
Since I'm splitting up the validator.js file into validator-full.js a…
5b40d68 
…nd (#3292)

validator-light.js, I'd like to expand the whitelisted files in the
presubmit checks to validator-full.js. This should make the presubmits
happy for #3282.
@powdercloud
Copy link
Contributor Author

powdercloud commented May 24, 2016 •
edited
Loading

@Gregable Now ready for review.

@Gregable
Copy link
Member

LGTM

@powdercloud powdercloud merged commit 93c40d9 into ampproject:master May 24, 2016
@powdercloud powdercloud deleted the from-the-department-of-churn branch May 24, 2016 20:15
@snyk-bot snyk-bot mentioned this pull request Nov 2, 2021
Open
This was referenced Dec 15, 2021
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Dec 30, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Gregable Gregable

Labels
WG: caching
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@powdercloud @Gregable @honeybadgerdontcare