Update amp-form docs and add an expanded note on CORS security. #4485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
adding @dvoytenko to this since he has done a few of the CORS documentation |
mkhatib
force-pushed
the
forms-cors-security-docs
branch
from
3b5efc6
to
183d601
Compare
| __optional__ | ||
| You can also provide an action-xhr attribute, if provided, the form will be submitted in an XHR fashion. | ||
|
|
||
| This attribute can be the same or a different endpoint that action and has the same action requirement above. |
There was a problem hiding this comment.
"than action" and let's make it action.
There was a problem hiding this comment.
Also, "requirements" (plural)
|
LGTM |
|
LGTM with few comments |
|
|
||
| ## Events | ||
| `amp-form` exposes 3 events: | ||
| **submit** |
There was a problem hiding this comment.
Can you add a line before this line. The "submit" line is showing up at the end of the above line with the colon.
Might also want to consider making these three a bulleted list.
| @@ -75,7 +75,108 @@ __required__ | |||
|
|
|||
| Action must be provided, `https` and is non-cdn link (does **NOT** link to https://cdn.ampproject.org). | |||
|
|
|||
| **action-xhr** | |||
| __optional__ | |||
There was a problem hiding this comment.
add parentheses on optional
| All other [form attributes](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/form) are optional. | ||
|
|
||
| ## Inputs | ||
| Currently, `<input type=button>`, `<input type=file>`, `<input type=image>` and `<input type=password>` are not allowed. (This might be reconsidered in the future - please let us know if you require these and use cases). | ||
|
|
||
| ## Events | ||
| `amp-form` exposes 3 events: |
There was a problem hiding this comment.
this is formatted wrong, theres no new line before submit
There was a problem hiding this comment.
Updated in subsequent pushes.
ariangibson
pushed a commit
to Mixpo/amphtml
that referenced
this pull request
Sep 7, 2016
mityaha
pushed a commit
to ooyala/amphtml
that referenced
this pull request
Nov 30, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ITI: #3343