Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make screen readers announce changes in the slides carousel. #5892

Merged
merged 1 commit into from
Oct 28, 2016
Merged

Make screen readers announce changes in the slides carousel. #5892

merged 1 commit into from
Oct 28, 2016

Conversation

cramforce
Copy link
Member

Fixes #5485

aghassemi
aghassemi approved these changes Oct 28, 2016
View reviewed changes
Copy link
Contributor

@aghassemi aghassemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cramforce cramforce merged commit 90c965d into ampproject:master Oct 28, 2016
samiamorwas pushed a commit to samiamorwas/amphtml that referenced this pull request Oct 31, 2016
Merge branch 'master' of https://github.com/ampproject/amphtml into a…
314d2b1 
…mp_reddit_extension

* 'master' of https://github.com/ampproject/amphtml: (121 commits)
  `#setOwner` should rewrite `resource.owner_` value if it exist (ampproject#5898)
  Defer full upgrade until the element is connected (ampproject#5908)
  Skeleton for an amp-animation component (ampproject#5891)
  Use upgrade callback to pick the correct carousel class. (ampproject#5899)
  Add alert role to user-notification by default (ampproject#5896)
  Fix test-iframe-createIframeWithMessageStub failures on older browsers (ampproject#5895)
  Make screen readers announce changes in the slides carousel. (ampproject#5892)
  Separate out implementaton of document-info and remove dependency of … (ampproject#5864)
  Fixed assertion in key fetch function. (ampproject#5854)
  Track impression on amp landing page (ampproject#5606)
  Backward compatible way of stringifying Uint8Array (ampproject#5881)
  Ensure that a friendly-iframe embed cancels any boilerplate when ready (ampproject#5863)
  Fix amp-forms broken and flakey tests. (ampproject#5835)
  Make SW test properly skip when Request == undefined (ampproject#5876)
  Add Preamble section to AMP Cache Guidelines (ampproject#5873)
  Adding Adverline to amp-ad (ampproject#5829)
  Clarify cache guidelines (ampproject#5874)
  Consider it as non-viewer mode if there is no "origin" in hash param. (ampproject#5867)
  [amp-youtube] autoplay and test suite to run across all video players that implement the video API (ampproject#5765)
  Update Forms Docs to reflect availability. (ampproject#5815)
  ...
Lith pushed a commit to Lith/amphtml that referenced this pull request Dec 22, 2016
@cramforce
Make screen readers announce changes in the slides carousel. (ampproj…
d1c934e 
…ect#5892)

Fixes ampproject#5485
Lith pushed a commit to Lith/amphtml that referenced this pull request Dec 22, 2016
@cramforce
Make screen readers announce changes in the slides carousel. (ampproj…
1cd4042 
…ect#5892)

Fixes ampproject#5485
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aghassemi aghassemi aghassemi approved these changes

Assignees

@aghassemi aghassemi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cramforce @aghassemi