Allow amp-form to update amp-state #6820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/to @mkhatib /cc @rudygalfi PTAL |
dreamofabear
force-pushed
the
form-bind-pure
branch
from
ac61ef3
to
150e34a
Compare
mkhatib
approved these changes
Jan 5, 2017
| user().error(TAG, 'Failed to parse state. Is it valid JSON?', e); | ||
| }); | ||
| this.updateState_(json, true); |
There was a problem hiding this comment.
Add a comment to indicate what's the second true parameter is. Like: this.updateState_(json, /*opt_isInit*/ true);
| @@ -251,13 +251,14 @@ export class AmpForm { | |||
| credentials: 'include', | |||
| requireAmpResponseSourceOrigin: true, | |||
| }).then(response => { | |||
| this.actions_.trigger(this.form_, 'submit-success', null); | |||
| this.triggerAction_(/** success */ true, response); | |||
There was a problem hiding this comment.
nit: /* success */ (no need for second asterisk) - same below
dreamofabear
commented
Jan 6, 2017
| @@ -251,13 +251,14 @@ export class AmpForm { | |||
| credentials: 'include', | |||
| requireAmpResponseSourceOrigin: true, | |||
| }).then(response => { | |||
| this.actions_.trigger(this.form_, 'submit-success', null); | |||
| this.triggerAction_(/** success */ true, response); | |||
| user().error(TAG, 'Failed to parse state. Is it valid JSON?', e); | ||
| }); | ||
| this.updateState_(json, true); |
jridgewell
pushed a commit
to jridgewell/amphtml
that referenced
this pull request
Jan 31, 2017
* initial commit for bind/form integration * fix type error * fix unit test * PR comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial for #6199.
<amp-state>