Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add amp-bind experiment #7157

Merged
merged 3 commits into from
Jan 23, 2017
Merged

Conversation

dreamofabear
Copy link

Partial for #6199.

/to @aghassemi /cc @cramforce

@aghassemi
Copy link
Contributor

@choumx Let's assert that the experiment is enabled in amp-bind.js as part of this PR.

@dreamofabear
Copy link
Author

amp-bind.js only registers bind-impl.js and amp-state.js. The former already has an experiment toggle and I just added one to the latter. Thanks!

@dreamofabear dreamofabear merged commit 9a464b2 into ampproject:master Jan 23, 2017
@dreamofabear dreamofabear deleted the bind-experiment branch January 23, 2017 19:57
jridgewell pushed a commit to jridgewell/amphtml that referenced this pull request Jan 31, 2017
* add amp-bind experiment

* add experiment check to amp-state

* fix unit test
mrjoro pushed a commit to mrjoro/amphtml that referenced this pull request Apr 28, 2017
* add amp-bind experiment

* add experiment check to amp-state

* fix unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants