Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional descriptive documentation for AMP layouts #729

Merged
merged 1 commit into from
Oct 24, 2015
Merged

Additional descriptive documentation for AMP layouts #729

merged 1 commit into from
Oct 24, 2015

Conversation

dvoytenko
Copy link
Contributor

Closes #677.

@dvoytenko dvoytenko force-pushed the layoutdocs1 branch 2 times, most recently from ff52176 to 58f9b9a Compare October 23, 2015 02:00
cramforce
cramforce reviewed Oct 23, 2015
View reviewed changes
spec/amp-html-layout.md

### `fixed`

The element has a fixed width and height that do not change.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"that do not change" is a bit confusing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rewrote.

@cramforce
Copy link
Member

LGTM

dvoytenko added a commit that referenced this pull request Oct 24, 2015
@dvoytenko
Merge pull request #729 from dvoytenko/layoutdocs1
4c72dce 
Additional descriptive documentation for AMP layouts
@dvoytenko dvoytenko merged commit 4c72dce into ampproject:master Oct 24, 2015
@dvoytenko dvoytenko deleted the layoutdocs1 branch October 24, 2015 00:29
@uditalias uditalias mentioned this pull request Nov 4, 2022
Open
@Elisabeth1983 Elisabeth1983 mentioned this pull request Nov 4, 2022
Open
@Masterci84 Masterci84 mentioned this pull request Nov 5, 2022
Open
@muratkalenderoglu muratkalenderoglu mentioned this pull request Nov 5, 2022
Open
@terrorizer1980 terrorizer1980 mentioned this pull request Nov 5, 2022
Closed
@shmoop207 shmoop207 mentioned this pull request Nov 15, 2022
Open
@Elisabeth1983 Elisabeth1983 mentioned this pull request Nov 15, 2022
Open
@Masterci84 Masterci84 mentioned this pull request Nov 16, 2022
Open
@muratkalenderoglu muratkalenderoglu mentioned this pull request Nov 16, 2022
Open
@terrorizer1980 terrorizer1980 mentioned this pull request Nov 16, 2022
Closed
@shmoop207 shmoop207 mentioned this pull request Nov 28, 2022
Open
@Elisabeth1983 Elisabeth1983 mentioned this pull request Nov 28, 2022
Open
@Masterci84 Masterci84 mentioned this pull request Nov 28, 2022
Open
@muratkalenderoglu muratkalenderoglu mentioned this pull request Nov 29, 2022
Open
@terrorizer1980 terrorizer1980 mentioned this pull request Nov 29, 2022
Closed
@snyk-bot snyk-bot mentioned this pull request Dec 6, 2022
Open
@Elisabeth1983 Elisabeth1983 mentioned this pull request Dec 25, 2022
Open
@shmoop207 shmoop207 mentioned this pull request Dec 25, 2022
Open
@Elisabeth1983 Elisabeth1983 mentioned this pull request Dec 25, 2022
Open
@Masterci84 Masterci84 mentioned this pull request Dec 25, 2022
Open
@muratkalenderoglu muratkalenderoglu mentioned this pull request Dec 26, 2022
Open
@terrorizer1980 terrorizer1980 mentioned this pull request Dec 26, 2022
Closed
@mohammed-ibra mohammed-ibra mentioned this pull request Feb 28, 2023
Open
@Elisabeth1983 Elisabeth1983 mentioned this pull request Oct 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cramforce cramforce

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dvoytenko @cramforce