Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(history): fix url turning into /undefined in IE11/Edge #746

Merged
merged 1 commit into from
Oct 25, 2015

Conversation

erwinmombay
Copy link
Member

No description provided.

@erwinmombay
Copy link
Member Author

fixes #743

@@ -282,7 +282,13 @@ export class HistoryBindingNatural_ {
};
replaceState = (state, opt_title, opt_url) => {
this.unsupportedState_ = state;
this.origReplaceState_(state, opt_title, opt_url);
// NOTE: check for `undefined` since IE11 and Edge
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat bug.

@reybango where is the best place to file this?

@cramforce
Copy link
Member

LGTM

erwinmombay added a commit that referenced this pull request Oct 25, 2015
fix(history): fix url turning into /undefined in IE11/Edge
@erwinmombay erwinmombay merged commit f268934 into ampproject:master Oct 25, 2015
@erwinmombay erwinmombay assigned cramforce and unassigned dvoytenko Oct 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants