amp-viewer-integration support string messages from webview #8165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenshay
changed the title
|
Hi, ampproject bot here! Here are a list of the owners that can approve your files. You may leave an issue comment stating "@ampprojectbot retry!" to force me to re-evaluate this Pull Request's status /to cramforce dvoytenko jridgewell
/to camelburrito lannka
For any issues please file a bug at https://github.com/google/github-owners-bot/issues |
chenshay
changed the title
dvoytenko
approved these changes
Mar 15, 2017
| if (message.type == MessageType.REQUEST) { | ||
| this.handleRequest_(message); | ||
| this.handleRequest_(/** @type {Message} */(message)); |
There was a problem hiding this comment.
Move cast above to const message = ...
examples/viewer-integr-messaging.js
Outdated
| @@ -31,18 +31,19 @@ var APP = '__AMPHTML__'; | |||
| * https://developer.mozilla.org/en-US/docs/Web/API/Channel_Messaging_API | |||
| */ | |||
| class WindowPortEmulator { | |||
| constructor(messageHandlers, id, port) { | |||
| constructor(messageHandlers, id, port, opt_isWebview) { | |||
There was a problem hiding this comment.
The actual code below is preferred. There you only use pass isWebview to the Messaging class. It'd be better here as well.
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Apr 28, 2017
…ct#8165) * stringify webview messages * check-types fix * in progress * test fix * cleanup * cleanup * fixes * fix viewer2.html * fixes * remove console.log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
amp-viewer-integration:
The messages from the webview arrive as strings. Support this.
close #8182