Fix double drain bug #8297
Closed
Fix double drain bug #8297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, ampproject bot here! Here are a list of the owners that can approve your files. You may leave an issue comment stating "@ampprojectbot retry!" to force me to re-evaluate this Pull Request's status /to dvoytenko jridgewell
For any issues please file a bug at https://github.com/google/github-owners-bot/issues |
jridgewell
requested changes
Mar 21, 2017
| @@ -61,7 +61,8 @@ export class BatchedXhr extends Xhr { | |||
| const fetchPromise = super.fetch(input, opt_init); | |||
|
|
|||
| if (isBatchable) { | |||
There was a problem hiding this comment.
Nit: Let's rearrange a bit:
if (!isBatchable) {
return fetchPromise
}
if (this.fetchPromises_[key]) {
return this.fetchPromises_[key].then(resp => resp.clone());
}
this.fetchPromises_[key] = fetchPromise;
return fetchPromise.then(...)
|
After some more thought, this may not be necessary. I will close this PR unless you think the nit you raised above should be carried to the code before this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the issue @jridgewell raised since it temporarily caches the original response and only gives callers cloned responses. The previous implementation cached a cloned response and returned it, allowing a potential double drain.