Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terser syntax for exporting identifiers #263

Merged
merged 3 commits into from
Dec 29, 2019
Merged

Conversation

kristoferbaxter
Copy link
Contributor

When exporting identifiers, we can avoid creating a variable reference to the name we want to export.

Also, we never currently inline export (even for sole export in a module) since we do not restore the name of the original export across the module.

@codecov-io
Copy link

codecov-io commented Dec 29, 2019

Codecov Report

Merging #263 into master will increase coverage by 0.11%.
The diff coverage is 98.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #263      +/-   ##
==========================================
+ Coverage   94.83%   94.94%   +0.11%     
==========================================
  Files          14       14              
  Lines        1432     1485      +53     
  Branches      142      151       +9     
==========================================
+ Hits         1358     1410      +52     
- Misses         70       71       +1     
  Partials        4        4
Impacted Files Coverage Δ
src/transformers/exports.ts 94.79% <100%> (+0.4%) ⬆️
src/transformers/imports.ts 97.04% <96.77%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09254e4...3692bce. Read the comment docs.

@kristoferbaxter kristoferbaxter merged commit 71fb830 into master Dec 29, 2019
@kristoferbaxter kristoferbaxter deleted the export-identifier branch December 29, 2019 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants