Update connection.ts - operationTimeoutInSeconds is reset to default #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bogdanbrudiu thanks for the PR. could you add a unit case that covers issue? |
jeremymeng
reviewed
Apr 30, 2024
| @@ -253,7 +253,7 @@ export class Connection extends Entity { | |||
| } | |||
|
|
|||
| this.options = this._connection.options; | |||
| this.options.operationTimeoutInSeconds = options?.operationTimeoutInSeconds ?? defaultOperationTimeoutInSeconds; | |||
| this.options.operationTimeoutInSeconds = this.options?.operationTimeoutInSeconds ?? defaultOperationTimeoutInSeconds; | |||
There was a problem hiding this comment.
I am not sure which one we should take when both this._connection.options.operationTimeoutInSeconds and options.operationTimeoutInSeconds are valid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…value
Description
Brief description of the changes made in the PR. This helps in making better changelog
operationTimeoutInSeconds - CreatedRheaConnectionOptions is not taken into consideration and the default 60 is used
rhea-promise/lib/connection.ts line 256
this.options.operationTimeoutInSeconds = options?.operationTimeoutInSeconds ?? defaultOperationTimeoutInSeconds;
Reference to any github issues