-
Notifications
You must be signed in to change notification settings - Fork 957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix -- handle uncategorized owners #2268
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Ben Dye <[email protected]>
Signed-off-by: Ben Dye <[email protected]>
Signed-off-by: Ben Dye <[email protected]>
Signed-off-by: Ben Dye <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ideally this should have a couple unit tests to help avoid issues around this feature in the future, might be worth it to write a couple quick ones
frontend/amundsen_application/static/js/components/OwnerEditor/index.tsx
Outdated
Show resolved
Hide resolved
// if any owners uncategorized, set section to null to render an uncategorized owners list | ||
Object.keys(itemProps).forEach((key) => { | ||
if (!itemProps[key].additionalOwnerInfo?.owner_category) { | ||
section = null; | ||
} | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this needed if you do the other check before this function is called? this feels like it might be more complicated than it needs to be
Signed-off-by: Ben Dye <[email protected]>
Description
Prior PR didn't handle the case of having owner categories configured, but also having some owners without any categories.
Motivation and Context
How Has This Been Tested?
Documentation
CheckList