Add defaulting Tableau site name

Default site name is '', and site name conf is optional. Signed-off-by: Shuichiro MAKIGAKI <[email protected]>
amundsen-io · Mar 30, 2021 · c3671d2 · c3671d2
1 parent dddf7a1
commit c3671d2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/databuilder/extractor/dashboard/tableau/tableau_dashboard_extractor.py b/databuilder/extractor/dashboard/tableau/tableau_dashboard_extractor.py
@@ -40,9 +40,9 @@ def execute(self) -> Iterator[Dict[str, Any]]:
                           if workbook['projectName'] not in
                           self._conf.get_list(TableauGraphQLApiMetadataExtractor.EXCLUDED_PROJECTS, [])]
         base_url = self._conf.get(TableauGraphQLApiMetadataExtractor.TABLEAU_BASE_URL)
-        site_name = self._conf.get_string(TableauGraphQLApiMetadataExtractor.SITE_NAME)
-        site_url_path = ""
-        if site_name != "":
+        site_name = self._conf.get_string(TableauGraphQLApiMetadataExtractor.SITE_NAME, '')
+        site_url_path = ''
+        if site_name != '':
             site_url_path = f'/site/{site_name}'
         for workbook in workbooks_data:
             if None in (workbook['projectName'], workbook['name']):

diff --git a/databuilder/extractor/dashboard/tableau/tableau_dashboard_utils.py b/databuilder/extractor/dashboard/tableau/tableau_dashboard_utils.py
@@ -154,7 +154,7 @@ def __init__(self, conf: ConfigTree) -> None:
         self._access_token_name = self._conf.get_string(TableauDashboardAuth.TABLEAU_ACCESS_TOKEN_NAME)
         self._access_token_secret = self._conf.get_string(TableauDashboardAuth.TABLEAU_ACCESS_TOKEN_SECRET)
         self._api_version = self._conf.get_string(TableauDashboardAuth.API_VERSION)
-        self._site_name = self._conf.get_string(TableauDashboardAuth.SITE_NAME)
+        self._site_name = self._conf.get_string(TableauDashboardAuth.SITE_NAME, '')
         self._api_base_url = self._conf.get_string(TableauDashboardAuth.API_BASE_URL)
         self._verify_request = self._conf.get(TableauDashboardAuth.VERIFY_REQUEST, None)