Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pandas 'nan' values when loading csv files #409

Merged
merged 1 commit into from
Nov 10, 2020
Merged

fix: pandas 'nan' values when loading csv files #409

merged 1 commit into from
Nov 10, 2020

Conversation

brebuanirello-equinix
Copy link
Contributor

Summary of Changes

Pandas detect missing values as default when reading a csv file. Due this configuration, Pandas was changing empty table and columns' descriptions to 'nan'. The solution is add one parameter when reading these csv files on pandas.read_csv( ) method
also passing na_filter=False can improve the performance of reading a large file.

Tests

N/A

Documentation

The documentation comes from oficial pandas lib

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
  • PR passes make test

Signed-off-by: bruno nirello <[email protected]>
@feng-tao feng-tao merged commit 3a28f46 into amundsen-io:master Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants