Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use query parameter for basic search [AtlasProxy] #105

Merged
merged 2 commits into from
May 29, 2020
Merged

feat: Use query parameter for basic search [AtlasProxy] #105

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70d5e8b
:tada: Initial commit.
mgorsk1 May 14, 2020
3ae9525
:fire: Removing code or files.
mgorsk1 May 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions search_service/proxy/atlas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,13 +208,7 @@ def fetch_table_search_results(self, *,
# return empty result for blank query term
return SearchResult(total_results=0, results=[])

# @todo switch to search with 'query' not 'filters' once Atlas FreeTextSearchProcessor is fixed
# https://reviews.apache.org/r/72440/
filters = [(self.ATLAS_QN_ATTRIBUTE, 'CONTAINS', query_term)]

# conduct search using filter on qualifiedName (it already contains both dbName and tableName)
# and table description
query_params = self._prepare_basic_search_query(self.page_size, page_index, filters=filters, operator='OR')
query_params = self._prepare_basic_search_query(self.page_size, page_index, query_term=query_term)

tables, approx_count = self._atlas_basic_search(query_params)

Expand Down