Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use swagger for user model #111

Merged
merged 5 commits into from
Jun 16, 2020
Merged

refactor: use swagger for user model #111

merged 5 commits into from
Jun 16, 2020

Conversation

feng-tao
Copy link
Member

@feng-tao feng-tao commented Jun 9, 2020

Summary of Changes

use swagger for user model

Tests

What tests did you add or modify and why? If no tests were added or modified, explain why. Remove this line

Documentation

What documentation did you add or modify and why? Add any relevant links then remove this line

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
  • PR passes make test

@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2020

Codecov Report

Merging #111 into master will increase coverage by 0.15%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
+ Coverage   74.76%   74.92%   +0.15%     
==========================================
  Files          18       18              
  Lines         650      654       +4     
  Branches       85       86       +1     
==========================================
+ Hits          486      490       +4     
  Misses        135      135              
  Partials       29       29              
Impacted Files Coverage Δ
search_service/api/user.py 40.00% <ø> (-13.85%) ⬇️
search_service/proxy/atlas.py 49.03% <ø> (ø)
search_service/proxy/base.py 68.18% <ø> (ø)
search_service/proxy/elasticsearch.py 73.50% <0.00%> (ø)
search_service/models/user.py 95.45% <100.00%> (+2.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17c6739...6cc919d. Read the comment docs.

Copy link
Contributor

@jinhyukchang jinhyukchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Were you able to do integration test on user search?

@feng-tao
Copy link
Member Author

@jinhyukchang , yeap, confirm on our staging.

@jinhyukchang
Copy link
Contributor

@jinhyukchang , yeap, confirm on our staging.

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants