Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add pypi publish action #130

Merged
merged 1 commit into from
Aug 18, 2020
Merged

chore: add pypi publish action #130

merged 1 commit into from
Aug 18, 2020

Conversation

feng-tao
Copy link
Member

Signed-off-by: feng-tao [email protected]

Summary of Changes

same as metadata / fe which I will keep the travis until add another one for docker push(in a different pr).

Tests

What tests did you add or modify and why? If no tests were added or modified, explain why. Remove this line

Documentation

What documentation did you add or modify and why? Add any relevant links then remove this line

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
  • PR passes make test

Copy link
Member

@Golodhros Golodhros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@feng-tao feng-tao merged commit 69fa138 into master Aug 18, 2020
@feng-tao feng-tao deleted the tfeng_add_action branch August 18, 2020 17:07
jerryzhu2007 pushed a commit to kylg/amundsensearchlibrary that referenced this pull request Aug 20, 2020
* commit '5eb3c20c3d98e0563a00dcf632e42baa7ee81c15':
  chore: replace references to Lyft with Amundsen (amundsen-io#133)
  chore: fix docker push action (amundsen-io#132)
  chore: add docker publish action and remove travis (amundsen-io#131)
  chore: add pypi publish action (amundsen-io#130)
  ci: add dependabot config (amundsen-io#128)
  chore: apply license headers to all the source files (amundsen-io#116)
  chore: update the email for the project (amundsen-io#114)

# Conflicts:
#	README.md
#	setup.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants