Use zstd over gzip when not compiling for WASM #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpeddicord
reviewed
Jun 27, 2019
NOTE: At least on my machine, this doesn't compile correctly for wasm, as the zstd features don't seem to be working correctly, eg ZSTD_LEGACY_SUPPORT=1 is passed to the C compiler, even though that feature should be disabled.
26 tasks
|
Great changes, thank you! I think this looks good to merge; I'm taking care of my usual Monday fun and will merge this in later today. Don't worry too much about wasm; it's an eventual goal but it's still very experimental as far as askalono is concerned. |
|
Cool, no rush! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #43
Description of changes:
This replaces the use of a gzip with zstd for compression the spdx archive, which results in a much smaller cache/binary, and very slightly faster decompression. This change does not affect WASM however, as zstd is not out of the box compatible with wasm, and a cursory glance didn't show any feature toggles that might be used to make it so, so that WASM path still uses gzip.
I also made a slight change to the LicenseMatch to just return a
&strrather than a newString, as well as replace the use of the macro in the analyze pass with a normal closure.I also fixed some warnings.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.