Trigger mechanism for pattern and signal generator #149
+415
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teoperisanu
force-pushed
the
pattern-generator-trigger
branch
2 times, most recently
from
785646b
to
a946357
Compare
|
Trigger out is a different functionality of the external trigger. I think this functionality is coherent with the rest of the triggers and should be in the same class - not separate classes - they should be merged. |
adisuciu
reviewed
May 28, 2020
include/libm2k/enums.hpp
Outdated
| enum M2K_TRIGGER_OUT_SOURCE_DIGITAL { | ||
| DIGITAL_OUT_SRC_NONE = 0, ///< DIGITAL_OUT_SRC_NONE - no trigger events | ||
| DIGITAL_OUT_SRC_TRIGGER_IN = 1, ///< DIGITAL_OUT_SRC_TRIGGER_IN - trigger events on the TI(trigger in) pin trigger the DigitalOut interface | ||
| DIGITAL_OUT_SRC_TRIGGER_OUT = 2, ///< DIGITAL_OUT_SRC_TRIGGER_OUT - trigger events on the TO(trigger out) pin trigger the DigitalOut interface |
There was a problem hiding this comment.
These enums should be named TRIGGER_OUT_SRC_*
teoperisanu
force-pushed
the
pattern-generator-trigger
branch
from
a946357
to
3696e12
Compare
teoperisanu
changed the title
teoperisanu
force-pushed
the
pattern-generator-trigger
branch
from
3696e12
to
4ccbbab
Compare
cristina-suteu
force-pushed
the
pattern-generator-trigger
branch
from
9d1c9bf
to
4ccbbab
Compare
added 3 commits
February 4, 2021 18:12
Both DACs and pattern generator share common functionalities. These features will be available in a future firmware version, so we have separated these from the others, in a new class - M2kHwTrigger_v0.26. Signed-off-by: Teo Perisanu <[email protected]>
Add the digital device. Implement the functionalities based on the generic definitions. Signed-off-by: Teo Perisanu <[email protected]>
Both DACs share the same trigger mechanism - only one DAC should be used in order to configure the triggering system. Implement the functionalities based on the generic definitions. Signed-off-by: Teo Perisanu <[email protected]>
cristina-suteu
force-pushed
the
pattern-generator-trigger
branch
from
9918ca6
to
9d8c31d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is only a draft. The merge can be performed only after the official firmware is released.
Add the functionality of setting a trigger for the DigitalOut and AnalogOut interface. This enhancement is described in #148.