Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for LTC7841 #2631

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

MarielTinaco
Copy link
Contributor

Add LTC7841 to compatible devices of LTC2978.

LTC7841 is a PolyPhase Synchronous Boost Controller with PMBus Interface.

ltc2978.c

  • Add chip ID to compatible devices
  • Inserted chip name into comments where the device share register addresses
  • Added its own chip info condition in the probe function

bindings

  • Add to documentation
  • Add header line for SPDX license in Documentation/hwmon/ltc2978.rst, it raises checkpatch error

PR Type

  • Bug fix (a change that fixes an issue)
  • New feature (a change that adds new functionality)
  • Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

  • I have conducted a self-review of my own code changes
  • I have tested the changes on the relevant hardware
  • I have updated the documentation outside this repo accordingly (if there is the case)

Add LTC7841 to supported devices of LTC2978

Signed-off-by: Mariel Tinaco <[email protected]>
Add LTC7841 to compatible devices of LTC2978

Signed-off-by: Mariel Tinaco <[email protected]>
Add support for LTC7841. The LTC7841 is a high performance
PolyPhase® single output synchronous boost converter controller.
Multiphase operation reduces input and output capacitor
requirements and allows the use of smaller inductors than the
single-phase equivalent.

The relevant registers in the LTC7841 are identical to the
LTC7880. So it's just a matter of adding the chip id.

Signed-off-by: Mariel Tinaco <[email protected]>
Copy link
Collaborator

@nunojsa nunojsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the comment on the bindings patch, LGTM. Go ahead and send it upstream :)

@@ -16,6 +16,7 @@ Required properties:
* "lltc,ltc3886"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment to the commit message. You likely need a bit more detail in explaining some slight differences between the new device and the already supported ones (DT maintainers are normally picky with commit messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants