Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for adxl380 and adxl382 #612

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

rbudai98
Copy link
Contributor

@rbudai98 rbudai98 commented Nov 1, 2024

Description

Add py-adi support for adxl380 and adxl382

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

Test Configuration:

  • Hardware: RPi4 + eval board adxl38x
  • OS: Kuiper and liunx driver

Documentation

If this is a new feature or example please mention or link any documentation. All new hardware interface classes require documentation.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have signed off all commits and they contain "Signed-off by: "
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

github-actions bot commented Nov 1, 2024

Generated documentation for this PR is available at Link

supported_parts.md Show resolved Hide resolved
@@ -327,6 +327,14 @@ adxl345:
- filename: adxl345.xml
- data_devices:
- iio:device0
adxl380:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about adxl382 ?

Copy link
Contributor Author

@rbudai98 rbudai98 Nov 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since adxl380 and adxl382 have the same class structure, only one test should be enough

Copy link

github-actions bot commented Nov 1, 2024

Test Results

1 644 tests  +12     377 ✅ +12   11m 57s ⏱️ +4s
    1 suites ± 0   1 267 💤 ± 0 
    1 files   ± 0       0 ❌ ± 0 

Results for commit 30a47b9. ± Comparison against base commit 58c3827.

♻️ This comment has been updated with latest results.

<!ATTLIST attribute name CDATA #REQUIRED filename CDATA #IMPLIED value CDATA #IMPLIED>
<!ATTLIST debug-attribute name CDATA #REQUIRED value CDATA #IMPLIED>
<!ATTLIST buffer-attribute name CDATA #REQUIRED value CDATA #IMPLIED>]>
<context name="network" description="10.42.0.83 Linux analog 6.1.54-v7l+ #9 SMP Wed Oct 30 07:08:07 GMT 2024 armv7l" >
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete the ip or replace it with 127.0.0.1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@rbudai98
Copy link
Contributor Author

rbudai98 commented Nov 4, 2024

v2:

  • applied PR comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants