-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test functions to test new unify function #1
Conversation
@anaradanovic Hi Ana! Let's hold off on merging this until we can chat more tomorrow :) |
Ok, pytest is passing!!! |
@pytest.mark.parametrize( | ||
"instance", ("raw", "epochs", "evoked", "raw_spectrum", "epochs_spectrum") | ||
) | ||
def test_instance_support(instance, request, evoked): | ||
"""Tests support of different classes.""" | ||
# test unify_bads function on instance (single input, no bads scenario) | ||
inst = _get_inst(instance, request, evoked) | ||
inst_out = unify_bad_channels([inst]) | ||
assert inst_out == [inst] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can be removed, only need to test one instance type.
m_out = unify_bad_channels([one_bad, no_bad, three_bad]) | ||
assert len(m_out) == 3 | ||
correct_bads = [chns[1], chns[0], chns[2]] | ||
for i in np.arange(len(m_out)): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for i in np.arange(len(m_out)): | |
for i in range(len(m_out)): |
Co-authored-by: Daniel McCloy <[email protected]>
@anaradanovic Hi Ana! Ok, Dan thinks that we're ready to accept this PR. |
Ok, now, actually for real we're ready to accept this PR! |
indeed! @anaradanovic please merge this one, then we'll do a final review/merge of the combined work |
Adds test functions to test unify_bad_channels.