[Fix] fix bug ignoring subsequent data in stream event #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this makes since. Thank you for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when a stream data event contains multiple data, only the first data is being parsed and processed, while the rest are being ignored. This results in incomplete processing of the stream data event.
Perhaps this issue #16 is caused by the same thing.
I had the same situation and when I checked the behavior in flutter web, I found the aforementioned problem.
The bug was caused by an incorrect return statement in the parsing code for stream data events, which caused the code to exit prematurely and prevented the processing of subsequent data in the event. To fix this, I replaced the return statement with a continue statement, allowing the code to continue processing subsequent data in the stream data event.
Sorry if this is hard to understand since it is a machine translation.
Please review and let me know if you have any feedback or suggestions.
Thank you.